Less 1.4 Compat #88
Less 1.4 Compat #88
Conversation
The less 1.4 beta requires all math to be done inside parenthesis.
The less 1.4 beta disallows unit inconsistency in math operations.
|
I would also love to have this PR merged @tylertate |
|
I guess the multiplication with 1px was to force the unit to be pixel. This is bad anyway, the developer should be able to determine the unit (I'd prefer ems for example). |
|
@matthewwithanm does this work in ems, whenever I tested removing * 1px; in my project it would break the grid. The math just did not always add up when I used ems. BTW I admit I have to update it to less 1.4 and will attempt to do this in the next few weeks. |
|
Any update on this one? After upgrading to lessc 1.4 I got pretty much broken designs on most of my sites. |
|
I'm using this although nested columns are not working correctly. It gives the article a width of 63.888888888888886% (should be around 47%). If I change it to just .column(6) then it works fine but not in IE 7 |
Less 1.4 has a couple of breaking changes; namely, math needs to be wrapped in parens and mixed-unit math is disallowed. So I wrapped all the math in parens.
The one occurrence of mixed-unit math was in the calculation of
@gridsystem-width. I removed the pixels unit but, honestly, I'm not sure why the value was being multiplied by 1px in the first place. I assumed it was to coerce less into rounding or something, but it didn't seem to be making a difference for me with 1.4 or 1.3.3. Which is just a roundabout way of saying that I'm not sure if b32266d is kosher, or whether something more complicated needs to be done (: Just in case, I kept it as a separate commit.